[webkit-reviews] review denied: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17177] Use FrameLoader::shouldTreatURLAsLocal from SecurityOrigin::canAccess

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 11:45:45 PST 2007

Sam Weinig <sam at webkit.org> has denied Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin

Attachment 17177: Use FrameLoader::shouldTreatURLAsLocal from

------- Additional Comments from Sam Weinig <sam at webkit.org>
r-.  I don't think adding the m_url member variable is a good solution as it
adds redundant information.  Either we should only have the m_url or we should
make a new method that takes the protocol and determines if it should be
treated as local (eg. FrameLoader::shouldTreatProtocolAsLocal).

More information about the webkit-reviews mailing list