[webkit-reviews] review requested: [Bug 15891] [GTK] Javascript console and dialogs are not implemented : [Attachment 17184] Changed signal arguments

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 15891: [GTK] Javascript console and dialogs are not implemented
http://bugs.webkit.org/show_bug.cgi?id=15891

Attachment 17184: Changed signal arguments
http://bugs.webkit.org/attachment.cgi?id=17184&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I agree with xan now that the default signals should be implemented similar to
event handlers in that a boolean return value indicates wether a signal was
handled and changed it accordingly.
I think there is a small bug with the prompt signal, but I decided to proceed
with this anyway.