[webkit-reviews] review cancelled: [Bug 15891] [GTK] Javascript console and dialogs are not implemented : [Attachment 17164] Style fixes and two issues pointed out by xan

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 06:14:37 PST 2007


Christian Dywan <christian at twotoasts.de> has cancelled Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 15891: [GTK] Javascript console and dialogs are not implemented
http://bugs.webkit.org/show_bug.cgi?id=15891

Attachment 17164: Style fixes and two issues pointed out by xan
http://bugs.webkit.org/attachment.cgi?id=17164&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I agree with xan now that the default signals should be implemented similar to
event handlers in that a boolean return value indicates wether a signal was
handled and changed it accordingly.
I think there is a small bug with the prompt signal, but I decided to proceed
with this anyway.


More information about the webkit-reviews mailing list