[webkit-reviews] review requested: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17177] Use FrameLoader::shouldTreatURLAsLocal from SecurityOrigin::canAccess

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 17:41:07 PST 2007

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin

Attachment 17177: Use FrameLoader::shouldTreatURLAsLocal from

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
This patch is using FrameLoader::shouldTreatURLAsLocal instead of 'file' in
SecurityOrigin::canAccess. isSecureTransition is not changed.
FrameLoader::shouldTreatURLAsLocal requires a String as argument and passing
m_protocol would not work  so I decided to keep the KURL::url() in m_url. I
wonder why the comparsion of 'file' is hardcoded and not KURL::isLocalFile is

I would like to receive comments regarding:

More information about the webkit-reviews mailing list