[webkit-reviews] review requested: [Bug 15813] Incorrect handling of findstr results in *.vcproj : [Attachment 17176] Fix handling results of findstr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 10 16:40:55 PST 2007

Hiroaki Nakamura <hnakamur at gmail.com> has asked  for review:
Bug 15813: Incorrect handling of findstr results in *.vcproj

Attachment 17176: Fix handling results of findstr

------- Additional Comments from Hiroaki Nakamura <hnakamur at gmail.com>
First, "echo on" was my mistake. I forgot removing them.

As for ERRORLEVEL, I read the help of cmd.exe and understand that "if
ERRORLEVEL n stmt1 else stmt2" means if errorlevel is greater than or equal to
n then execute stmt1 else execute stmt2. And findstr returns 0 when found, 1
when not found. So if you write "if ERRORLEVEL 0", stmt1 is always executed.

Also you need parenthesis if stmt1 is not one word. I tried without parenthesis
and it didn't work correctly. I tried on Japanese Windows Vista Home Edition.

And original project file was missing "else" for setting AnalyzeWithLargeStack.

More information about the webkit-reviews mailing list