[webkit-reviews] review granted: [Bug 15835] Switch List to Vector
(.5% speedup) : [Attachment 17039] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 4 16:44:33 PST 2007
Darin Adler <darin at apple.com> has granted 's request for review:
Bug 15835: Switch List to Vector (.5% speedup)
http://bugs.webkit.org/show_bug.cgi?id=15835
Attachment 17039: Patch
http://bugs.webkit.org/attachment.cgi?id=17039&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The best idiom for iterating a vector is to use indices and not bother with
iterator objects at all. I believe it's faster than the iterator version, and
certainly more readable!
But for speed, you'd want a version that doesn't do a range check each time.
r=me (as is -- those comments above are "food for thought")
More information about the webkit-reviews
mailing list