[webkit-reviews] review granted: [Bug 15834] There are many subtle bugs in the Styles pane of the Web Inspector : [Attachment 17038] Patch

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=15834

Attachment 17038: Patch
http://bugs.webkit.org/attachment.cgi?id=17038&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+	 Bug 15834: There are many subtile bugs in the Styles pane of the Web
Inspector

Typo: Subtile -> Subtle

+	 for (var i = 0; i < boxes.length; ++i) {
+	     var name = boxes[i];

Even though you've defined name here, you still use boxes[i] later on.

It looks like PropertiesSidebarPane.js has a bunch of tabs in it.

I'm not really sure what the changes to the TreeOutline code are supposed to be
doing (the ChangeLog didn't mention them).

r=me