[webkit-reviews] review granted: [Bug 13722] Finish testing and fixing the setting of DOM attributes to JS null : [Attachment 14570] patch to fix Core DOM attributes

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 13722: Finish testing and fixing the setting of DOM attributes to JS null
http://bugs.webkit.org/show_bug.cgi?id=13722

Attachment 14570: patch to fix Core DOM attributes
http://bugs.webkit.org/attachment.cgi?id=14570&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
How about using dumpAsText for this test?

	 [ConvertNullStringTo=Null, OldStyleObjC] DOMString substringData(in
[IsIndex] unsigned long offset, 
-							    in [IsIndex]
unsigned long length)
+									  in
[IsIndex] unsigned long length)

I'm not a big fan of "high-maintenance" formatting that requires changes to
indentation when you rename things or add keywords. Maybe we can reconsider the
way we're formatting .idl files at some point.

r=me