[webkit-reviews] review requested: [Bug 13722] Finish testing and fixing the setting of DOM attributes to JS null : [Attachment 14570] patch to fix Core DOM attributes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 10:33:08 PDT 2007


Sam Weinig <sam at webkit.org> has asked  for review:
Bug 13722: Finish testing and fixing the setting of DOM attributes to JS null
http://bugs.webkit.org/show_bug.cgi?id=13722

Attachment 14570: patch to fix Core DOM attributes
http://bugs.webkit.org/attachment.cgi?id=14570&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
This patch fixes the remaining attributes in the Core DOM (CharacterData.data,
ProcessingInstruction.data, and Attr.value).  Patched Attr.value to not throw
an exception for null values as this matches the spec and Firefox.



More information about the webkit-reviews mailing list