[webkit-reviews] review requested: [Bug 13688] REGRESSION (r20943+): Colloquy doesn't show any messages : [Attachment 14504] Patch to fix bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 23:45:46 PDT 2007


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 13688: REGRESSION (r20943+): Colloquy doesn't show any messages
http://bugs.webkit.org/show_bug.cgi?id=13688

Attachment 14504: Patch to fix bug
http://bugs.webkit.org/attachment.cgi?id=14504&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The behavior in this patch exactly matches Gran Paradiso Alpha 4.  Empty cells
(with no lines) had their baseline wrongly at the top in FFX2 (one of the
reasons it failed Acid2).  Now that the baseline of the cell is on the bottom,
Gran Paradiso Alpha 4 passes this test case as well.  I even tried putting text
in cell 2 in the test case, wondering if the cell would move such that it hung
out of the table itself.  It did indeed do that with both my patch and Gran
Paradiso.



More information about the webkit-reviews mailing list