[webkit-reviews] review requested: [Bug 13618] HTMLAnchorElement should not force target to _blank for middle clicks : [Attachment 14500] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 11 19:31:31 PDT 2007


Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 13618: HTMLAnchorElement should not force target to _blank for middle
clicks
http://bugs.webkit.org/show_bug.cgi?id=13618

Attachment 14500: patch v3
http://bugs.webkit.org/attachment.cgi?id=14500&action=edit

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
This moves the functions to the Private section and fixes the whitespace
issues.

Unlike the last patch, this one is untested (my access to a Mac is limited), so
please make sure it compiles :)

I don't know of any way to make a testcase for this, but with the last patch I
did at least use a debugger to verify the preference had been set correctly
when stepping through the HTMLAnchorElement code.



More information about the webkit-reviews mailing list