[webkit-reviews] review granted: [Bug 7452] <wbr> in <pre> causes some new lines to be ignored : [Attachment 14449] patch that implements proper parsing and rendering for <wbr>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 13:41:52 PDT 2007


mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 7452: <wbr> in <pre> causes some new lines to be ignored
http://bugs.webkit.org/show_bug.cgi?id=7452

Attachment 14449: patch that implements proper parsing and rendering for <wbr>
http://bugs.webkit.org/attachment.cgi?id=14449&action=edit

------- Additional Comments from mitz at webkit.org
+++ WebCore/dom/Node.cpp	(working copy)

Please include the changes to Node.cpp in the change log. Did you actually hit
a case where createRenderer() returned 0 despite rendererIsNeeded() returning
true? If not, can you replace or augment the if(r) with an ASSERT(r)?

What's the following all about?

Property changes on: LayoutTests/fast/text/wbr.html
___________________________________________________________________
Name: svn:executable
   + *

r=me



More information about the webkit-reviews mailing list