[webkit-reviews] review granted: [Bug 13572] Arabic characters are not correctly joined when using Arial : [Attachment 14476] Add a private stripped-down version of u_shapeArabic that handles the non-Arabic languages

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13572: Arabic characters are not correctly joined when using Arial
http://bugs.webkit.org/show_bug.cgi?id=13572

Attachment 14476: Add a private stripped-down version of u_shapeArabic that
handles the non-Arabic languages
http://bugs.webkit.org/attachment.cgi?id=14476&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm surprised by the function name. In what way is this Macintosh-specific?

It's hard to review the differences in this between the ICU version and the new
version because the diff just shows the new code.

I don't think we need to use U_CAPI and U_EXPORT2 in an internal WebCore
header.

Typically we capitalize filenames, so I would call this ShapeArabicMac.h/cpp.

I'm comfortable with this patch despite those concerns. So I'm going to mark
this review+ -- feel free to clear the review flag if you want to do a new
version.