[webkit-reviews] review granted: [Bug 12936] Fix most remaining <use> bugs. : [Attachment 13437] Initial patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Mar 4 23:08:34 PST 2007

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12936: Fix most remaining <use> bugs.

Attachment 13437: Initial patch

------- Additional Comments from Darin Adler <darin at apple.com>
+    return svgElement;

Avoid reference count churn by saying return svgElement.release(), which allows
the RefPtr inside the function to give up the pointer without doing a ref
followed by a deref.

+    String widthString = String::number(width().value());
+    String heightString = String::number(height().value());

A shame to compute these both even when there's no width or height attribute. I
sugestmoving these expressions inside the if statements. You probably don't
need the local variables.

+		     String transformString = String::format("translate(%f,
%f)", use->x().value(), use->y().value());

I see this pattern repeated multiple times. I suggest some sort of helper
function to do this. Maybe a new function appendTransform(const FloatSize&) as
a member or just a helper function.

Do the two layout tests really cover all the problems?


More information about the webkit-reviews mailing list