[webkit-reviews] review granted: [Bug 12925] PathTraversalState's normalAngleAtLength/pointAtLength don't work. : [Attachment 13420] Update patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Mar 4 23:00:34 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12925: PathTraversalState's normalAngleAtLength/pointAtLength don't work.
http://bugs.webkit.org/show_bug.cgi?id=12925

Attachment 13420: Update patch
http://bugs.webkit.org/attachment.cgi?id=13420&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     static float rad2deg = 180.0 / M_PI;

Really should include "const" in there too.

Is there a way to test this so that the results are numeric instead of visual?
If so, I'd love to see a test like that as well as the visual one!

r=me



More information about the webkit-reviews mailing list