[webkit-reviews] review requested: [Bug 14147] REGRESSION: No history item created when viewing "All Sizes" on Flickr : [Attachment 15137] proposed patch

[bugzilla-daemon at webkit.org]

Maxime BRITTO <mbritto at pleyo.com> has asked  for review:
Bug 14147: REGRESSION: No history item created when viewing "All Sizes" on
Flickr
http://bugs.webkit.org/show_bug.cgi?id=14147

Attachment 15137: proposed patch
http://bugs.webkit.org/attachment.cgi?id=15137&action=edit

------- Additional Comments from Maxime BRITTO <mbritto at pleyo.com>
The call for scheduleLocationChange() in JSHTMLDocument::setLocation() 
(JSHTMLDocumentCustom.cpp) was missing an argument (userGesture) and the
default behavior in scheduleLocationChange() was to consider it false.
As this JS event was not considered as userGesture initiated, his load type was
internal and it wasn't added to the history.
With this modification I can no longer reproduce the bug