[webkit-reviews] review granted: [Bug 14207] REGRESSION: Crash after closing a tab with Google Maps Street View : [Attachment 15418] mitz test case & mbritto fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 8 05:04:34 PDT 2007


Darin Adler <darin at apple.com> has granted Maxime BRITTO <mbritto at pleyo.com>'s
request for review:
Bug 14207: REGRESSION: Crash after closing a tab with Google Maps Street View
http://bugs.webkit.org/show_bug.cgi?id=14207

Attachment 15418: mitz test case & mbritto fix
http://bugs.webkit.org/attachment.cgi?id=15418&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The comment "more efficient" is misleading. There's no efficiency problem here,
but rather inconsistent behavior.

The code should put instance->rootObject() into a local variable -- it's not
free and calling it twice is slower than calling it once.

But r=me anyway.



More information about the webkit-reviews mailing list