[webkit-reviews] review granted: [Bug 12384] getComputedStyle with td.style.display='none' reports '' for all properties except display : [Attachment 15442] Return rich computed style declarations for elements without renderers

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 12384: getComputedStyle with td.style.display='none' reports '' for all
properties except display
http://bugs.webkit.org/show_bug.cgi?id=12384

Attachment 15442: Return rich computed style declarations for elements without
renderers
http://bugs.webkit.org/attachment.cgi?id=15442&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    virtual RenderStyle* computedStyle() { return parent() ?
parent()->computedStyle() : 0; }

I don't think it's helpful to define a virtual function like this one as an
inline in the header. It's easier to modify it if it's even needed if you keep
it in the .cpp file instead, and it would only actually get inlined if it was a
non-virtual call, which should never happen in this case.

But that's a nitpick. This looks great!

I guess I was wrong about CSSStyleSelector needing a change!

r=me