[webkit-reviews] review denied: [Bug 14453] REGRESSION: www.nzherald.co.nz almost all the formating is gone : [Attachment 15385] This time with testcase and against ToT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 00:25:40 PDT 2007


Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 14453: REGRESSION: www.nzherald.co.nz almost all the formating is gone
http://bugs.webkit.org/show_bug.cgi?id=14453

Attachment 15385: This time with testcase and against ToT
http://bugs.webkit.org/attachment.cgi?id=15385&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This looks good, but not quite right. With this patch, every case in the parser
that allows HEX_OR_IDENT also allows IDSEL, so it doesn't seem good to have two
different tokens for these.

For the "specifier" production we allow characters that start with a numeric
character, as long as they happen to be 3 or 6 hex digits. That doesn't seem
right to me. Is our handling of such selectors consistent with other CSS
parsers?

I think that certain types of illegal colors would still malfunction with our
engine. For example, "#2bogus".

HEX_OR_IDENT is a strange name for a token that is # followed by either 3 or 6
hexadecimal digits. So if we keep it we should probably rename it.

Would you be willing to clean this up a bit more and straighten it out?



More information about the webkit-reviews mailing list