[webkit-reviews] review denied: [Bug 14442] Adding a stop with value 1.0 to a gradient that has already been used has no effect : [Attachment 15390] First attempt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 14442: Adding a stop with value 1.0 to a gradient that has already been
used has no effect
http://bugs.webkit.org/show_bug.cgi?id=14442

Attachment 15390: First attempt
http://bugs.webkit.org/attachment.cgi?id=15390&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Seems like a good idea.

But I don't think this is right yes. I don't think that findStop will return -1
for values that are less than the first stop; we need a test case that covers
that.

Also, I don't think the special cases in CanvasGradient::getColor for <= 0 and
>= 1 will work properly, since they assume that <= 0 and >= 1 are the first and
last stop. In fact, I suspect that was already broken since the sorting is done
inside findStop, and there's no guarantee it's called in those cases.