[webkit-reviews] review requested: [Bug 14207] REGRESSION: Crash
after closing a tab with Google Maps Street View :
[Attachment 15367] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 3 06:47:42 PDT 2007
Maxime BRITTO <mbritto at pleyo.com> has asked for review:
Bug 14207: REGRESSION: Crash after closing a tab with Google Maps Street View
http://bugs.webkit.org/show_bug.cgi?id=14207
Attachment 15367: proposed fix
http://bugs.webkit.org/attachment.cgi?id=15367&action=edit
------- Additional Comments from Maxime BRITTO <mbritto at pleyo.com>
Comments about the fix :
This fix is preventing the crash without any visible unexpected effects (on
GoogleMaps and on the Layout Tests).
The check for the instance on the constructor is not essential but I think it
may be useful to prevent future bugs which can look like this one. If the
reviewer don't like it he can remove it.
Comments about the test :
There is no test attached to this patch because we need to use tabs to
reproduce it and the DumpRenderTree doesn't handle them. If there is another
way to reproduce it I don't know it.
More information about the webkit-reviews
mailing list