[webkit-reviews] review granted: [Bug 14478] [gdk] Improve FontHandling, make valgrind happy : [Attachment 15353] Improve Gdk Font Handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 3 06:16:13 PDT 2007

Rob Buis <rwlbuis at gmail.com> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 14478: [gdk] Improve FontHandling, make valgrind happy

Attachment 15353: Improve Gdk Font Handling

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
>+	  to FontData::platformDestroy. The ownership of these objects is hold

Is held by.

>+	  Replace c-casts with c++ casts, in this case reinterpret_cast.
>+	  * platform/gdk/FontDataGdk.cpp:

I wouldn't do so many empty lines, but that is a style thing.
Code looks fine.

More information about the webkit-reviews mailing list