[webkit-reviews] review granted: [Bug 12311] Implement frame
loading for Qt. Clean up FrameLoader a bit : [Attachment
12610] new patch refactoring also the Mac code
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Tue Jan 23 01:44:45 PST 2007
Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12311: Implement frame loading for Qt. Clean up FrameLoader a bit
http://bugs.webkit.org/show_bug.cgi?id=12311
Attachment 12610: new patch refactoring also the Mac code
http://bugs.webkit.org/attachment.cgi?id=12610&action=edit
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me but please fix the following:
1) "pieced" in the ChangeLog should be "pieces"
2) The below should use HTMLFrameElementBase.
+ HTMLFrameElement* o = static_cast<HTMLFrameElement*>(ownerElement);
Also please test Java since the LayoutTests don't cover it.
More information about the webkit-reviews
mailing list