[webkit-reviews] review granted: [Bug 12134] REGRESSION: Assertion failure and crash when right clicking selection in forms : [Attachment 12448] Proposed fix

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12134: REGRESSION: Assertion failure and crash when right clicking
selection in forms
http://bugs.webkit.org/show_bug.cgi?id=12134

Attachment 12448: Proposed fix
http://bugs.webkit.org/attachment.cgi?id=12448&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

Why is there a default case in the switch statement in ContextMenu.cpp. In gcc,
all the default case does is turn off the often-useful warning for enum values
that have no case. If the switch value's type is not an enum, then a "default:
break" case does nothing.

I think getCustomMenuFromDefaultItems would read better with an early exit
rather than most of the function inside an if.

I also think it might be best to have this code only trigger on applications
compiled against the old WebKit. Tim Hatcher has the details about how we can
check this.

r=me