[webkit-reviews] review granted: [Bug 11197] REGRESSION: Specifying a counter for a CODE tag's content style property on before or after causes a crash. : [Attachment 12451] Proposed patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Jan 15 08:43:16 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11197: REGRESSION: Specifying a counter for a CODE tag's content style
property on before or after causes a crash.
http://bugs.webkit.org/show_bug.cgi?id=11197

Attachment 12451: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=12451&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I believe a better fix is to fix allAscii() to work when m_str is 0. Just
putting the for loop inside an if (m_str) would do the trick.

But this patch is also OK as-is.



More information about the webkit-reviews mailing list