[webkit-reviews] review requested: [Bug 12060] SVG needs to be wired into the shared attribute system : [Attachment 12453] Fixed patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Jan 15 05:53:53 PST 2007


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 12060: SVG needs to be wired into the shared attribute system
http://bugs.webkit.org/show_bug.cgi?id=12060

Attachment 12453: Fixed patch
http://bugs.webkit.org/attachment.cgi?id=12453&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This patch has a beautiful attribute lookup system.  Eventually perhaps that
system should be a .in file and auto-generated instead of being inline, but
it's OK for now.

One could make a test to check that <g width="10px"> is not actually mapped to
g.style.width, but I didn't bother.



More information about the webkit-reviews mailing list