[webkit-reviews] review requested: [Bug 11197] REGRESSION:
Specifying a counter for a CODE tag's content style property
on before or after causes a crash. : [Attachment 12451]
Proposed patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Mon Jan 15 03:45:35 PST 2007
Andrew Wellington <proton at wiretapped.net> has asked for review:
Bug 11197: REGRESSION: Specifying a counter for a CODE tag's content style
property on before or after causes a crash.
http://bugs.webkit.org/show_bug.cgi?id=11197
Attachment 12451: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=12451&action=edit
------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
A simple patch to resolve this issue.
Another possible point for this patch would be not calling cacheWidths() from
RenderText::setStyle if setText was not called. This is probably not a good
spot however as this is not the only place setText may be called to change
m_str's value.
More information about the webkit-reviews
mailing list