[webkit-reviews] review requested: [Bug 12251] REGRESSION (r18822-r18823): Assertion failure opening document with non-existent resources (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml) : [Attachment 12424] Patch v1

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Jan 14 05:06:46 PST 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 12251: REGRESSION (r18822-r18823): Assertion failure opening document with
non-existent resources (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml)
http://bugs.webkit.org/show_bug.cgi?id=12251

Attachment 12424: Patch v1
http://bugs.webkit.org/attachment.cgi?id=12424&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This is the obvious fix--to do the equivalent nil checking when retrieving an
object or removing it from the hash map.

Not sure if the callers of these methods should be smarter about when they call
them, e.g., after an attempt was made to load a resource that didn't exist.

Running layout tests now; will report results when completed.



More information about the webkit-reviews mailing list