[webkit-reviews] review denied: [Bug 12260] Windows platform build is not maintained : [Attachment 12422] Various fixes to make sure the Windows port compiles.

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 12260: Windows platform  build is not maintained
http://bugs.webkit.org/show_bug.cgi?id=12260

Attachment 12422: Various fixes to make sure the Windows port compiles.
http://bugs.webkit.org/attachment.cgi?id=12422&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
 }
-
 void FrameLoader::submitForm(const FrameLoadRequest& request, Event*)

    There should be blank lines between functions.

-	 virtual bool canTakeFocus(FocusDirection) = 0;
-	 virtual void takeFocus(FocusDirection) = 0;
+	 virtual bool canTakeFocus(WebCore::FocusDirection) = 0;
+	 virtual void takeFocus(WebCore::FocusDirection) = 0;

    The whole ChromeClient class declaration is in WebCore namespace, so this
shouldn't be needed (same with ContextMenuClient).

+bool ChromeClientWin::canTakeFocus (WebCore::FocusDirection)

    There should be no space after canTakeFocus.

+    notImplemented();
+	return false;

    The patch has a lot of tabs - please replace them with spaces.

 }
 
+
+void WebFrameLoaderClient::assignIdentifierToInitialRequest(unsigned long,
WebCore::DocumentLoader*, const WebCore::ResourceRequest&)

    Why did you add this blank line?

    Please include a ChangeLog with the patch.

  r- for the style issues. What are the remaining link errors?