[webkit-reviews] review denied: [Bug 11598] REGRESSION: NativePopUp: inner block is too big, causing focus ring to draw around clipped text : [Attachment 12373] Patch that fixes all the issues that kept buttons and popups from hit testing and repainting correctly

[bugzilla-request-daemon at macosforge.org]

mitz at webkit.org has denied mitz at webkit.org's request for review:
Bug 11598: REGRESSION: NativePopUp: inner block is too big, causing focus ring
to draw around clipped text
http://bugs.webkit.org/show_bug.cgi?id=11598

Attachment 12373: Patch that fixes all the issues that kept buttons and popups
from hit testing and repainting correctly
http://bugs.webkit.org/attachment.cgi?id=12373&action=edit

------- Additional Comments from mitz at webkit.org
Just listing here stuff we discussed on IRC:

Instead of overriding layout() and nodeAtPoint(), add hasControlClip() checks
at the end of RenderBlock's implementations.

Remove the display check as you said you will:

+    // Only need to check inline display.
+    if (noninherited_flags._effectiveDisplay == INLINE &&
+	 noninherited_flags._vertical_align !=
other->noninherited_flags._vertical_align)
	 return Layout;

Forgot to negate the last two:

-	 !(inherited_flags._text_decorations ==
other->inherited_flags._text_decorations) ||
-	 !(inherited_flags._force_backgrounds_to_white ==
other->inherited_flags._force_backgrounds_to_white) ||
-	 !(surround->border == other->surround->border) ||
+	 inherited_flags._text_decorations !=
other->inherited_flags._text_decorations ||
+	 inherited_flags._force_backgrounds_to_white ==
other->inherited_flags._force_backgrounds_to_white ||
+	 surround->border == other->surround->border ||