[webkit-reviews] review requested: [Bug 11598] REGRESSION: NativePopUp: inner block is too big, causing focus ring to draw around clipped text : [Attachment 12381] Patch take 2

[bugzilla-request-daemon at macosforge.org]

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 11598: REGRESSION: NativePopUp: inner block is too big, causing focus ring
to draw around clipped text
http://bugs.webkit.org/show_bug.cgi?id=11598

Attachment 12381: Patch take 2
http://bugs.webkit.org/attachment.cgi?id=12381&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch makes the changes mitz suggested.

I had to add a controlClipRect method, since all three controls were pushing
different clips.  In the process of doing this, I noticed opportunities to
clean up how list box reported its clip rect factoring in the scrollbar, so I
made that so that a lot of base class stuff would just automatically work from
JavaScript (like clientWidth/Height).

I also implemented scrollLeft/Top/Width/Height on listboxes, so that JS can
control the scroll position using pixel values (which we floor to determine the
desired option to snap to).