[webkit-reviews] review granted: [Bug 12851] improve gdk's notImplemented() macro : [Attachment 13309] improve gdk's notImplemented() macro

[bugzilla-request-daemon at macosforge.org]

Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12851: improve gdk's notImplemented() macro
http://bugs.webkit.org/show_bug.cgi?id=12851

Attachment 13309: improve gdk's notImplemented() macro
http://bugs.webkit.org/attachment.cgi?id=13309&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+#define notImplementedGdk() do { \
+    static int count; \
+    if (!count && !getenv("DISABLE_NI_WARNING")) \
+	 fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n",
WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
+    ++count; \
+ } while(0)

   Might as well just use a "bool printed" instead of "int count".

   Instead of putting this in config.h, you should probably just create your
own header platform/gdk/NotImplemented.h that only contains this macro.

   You might also want to uncomment any other notImplemented() calls that were
commented out for being too chatty.

   r=me.