[webkit-reviews] review requested: [Bug 12851] improve gdk's notImplemented() macro : [Attachment 13309] improve gdk's notImplemented() macro

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 21 22:30:50 PST 2007

Krzysztof Kowalczyk <kkowalczyk at gmail.com> has asked  for review:
Bug 12851: improve gdk's notImplemented() macro

Attachment 13309: improve gdk's notImplemented() macro

------- Additional Comments from Krzysztof Kowalczyk <kkowalczyk at gmail.com>
Improve gdk's notImplemented() macro():
* as suggested per Adam Roben in http://bugs.webkit.org/show_bug.cgi?id=12785,
only print once per function, so that frequently called functions don't clutter
the output
* rename to notImplementedGdk() to give it a unique name (so that it doesn't
clash with notImplemented() for other platforms)
* Don't print the warning if DISABLE_NI_WARNING env variable is set.

Is it ok to move notImplementedGdk() to some common place (e.g. config.h) to
avoid duplicating the code? If yes, I'll submit a patch for that in the future
(I renamed the macro to notImplementedGdk() in anticipation of that).

More information about the webkit-reviews mailing list