[webkit-reviews] review denied: [Bug 11139] Content types other than HTML are not handled : [Attachment 11074] Download support added

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 23:29:21 PST 2007


Oliver Hunt <oliver at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 11139: Content types other than HTML are not handled
http://bugs.webkit.org/show_bug.cgi?id=11139

Attachment 11074: Download support added
http://bugs.webkit.org/attachment.cgi?id=11074&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
+bool Image::supportsType(const String& mimeType)
 {
     // FIXME: Implement.
+    if (mimeType.startsWith("image/"))
+	 return true;
+    
     return false;
 }

Shouldn't link as Image::supportsType is defined in Image.cpp -- you should be
using the mimetyperegistry

which may or may not be implemented in windows -- i wrote it a while back, i
can't remember how much (if any) effort i put into making it crossplatform



More information about the webkit-reviews mailing list