[webkit-reviews] review requested: [Bug 12786] Crashes on arm due to different struct packing : [Attachment 13207] updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 23:28:26 PST 2007


Krzysztof Kowalczyk <kkowalczyk at gmail.com> has asked  for review:
Bug 12786: Crashes on arm due to different struct packing
http://bugs.webkit.org/show_bug.cgi?id=12786

Attachment 13207: updated patch
http://bugs.webkit.org/attachment.cgi?id=13207&action=edit

------- Additional Comments from Krzysztof Kowalczyk <kkowalczyk at gmail.com>
As per review comments:
* changed the test to #if COMPILER(GCC) && PLATFORM(ARM)
* move COMPILE_ASSERT to corresponding .cpp files to avoid #including
Assertions.h in *.h files

I don't think putting the PACK_STRUCT definition to config.h would be good
since it would require #including "config.h" in ustring.h and
DeprecatedString.h (at the moment no *.h files includes "config.h"). Platform.h
maybe? But that would require #including "Platform.h" in ustring.h and
DeprecatedString.h i.e. potentially longer compile times.



More information about the webkit-reviews mailing list