[webkit-reviews] review granted: [Bug 12602] XPath functions string(), normalize-space() and string-length() don't work without arguments : [Attachment 12922] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Feb 4 18:10:29 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12602: XPath functions string(), normalize-space() and string-length()
don't work without arguments
http://bugs.webkit.org/show_bug.cgi?id=12602

Attachment 12922: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12922&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Maybe we should nip this problem in the bud by getting rid of the Value
constructor that takes a bool. Instead that one could be private and we could
have a named constructor for making Value from a bool, like Value::fromBool().

r=me



More information about the webkit-reviews mailing list