[webkit-reviews] review granted: [Bug 6626] Arabic & Farsi rendered with no shaping (all glyphs separate, unreadable!) : [Attachment 12920] Use ICU to shape Arabic when the font does not contain shaping information

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 6626: Arabic & Farsi rendered with no shaping (all glyphs separate,
unreadable!)
http://bugs.webkit.org/show_bug.cgi?id=6626

Attachment 12920: Use ICU to shape Arabic when the font does not contain
shaping information
http://bugs.webkit.org/attachment.cgi?id=12920&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     if (isArabicLamWithAlefLigature(source[shapingEnd]) &&
source[shapingEnd + 1] == ' ')
+		 foundLigatureSpace = true;

It's more efficient and probably clear enough to just make this an assignment
rather than an if statement.

+    m_charBuffer = (UChar*)(font->isSmallCaps() ? new UChar[m_run.length()] :
0);

Why do we need a type cast here?

r=me