[webkit-reviews] review requested: [Bug 6484] font-weight does not properly support graded weights : [Attachment 12882] patch v 0.9

[bugzilla-request-daemon at macosforge.org]

Nicholas Shanks <contact at nickshanks.com> has asked  for review:
Bug 6484: font-weight does not properly support graded weights
http://bugs.webkit.org/show_bug.cgi?id=6484

Attachment 12882: patch v 0.9
http://bugs.webkit.org/attachment.cgi?id=12882&action=edit

------- Additional Comments from Nicholas Shanks <contact at nickshanks.com>
working patch for feedback. addresses every issue mentioned on either my or
alex's patches.
does not include tests or changelog yet

Issues:
1) I am not sure if all my "using namespace" and "@namespace" changes are
necessary
2) The FontManager <=> CSS weight conversion table needs tweaking (or something
else does) since "normal" gives a Light weight and "bold" gives an Extra Bold
weight. This is not considered significant for the purposes of the review
request.
3) Does not assert on NSBoldFontMask being passed in. Trait is ignored anyway,
and no longer used elsewhere so I don't see it necessary to assert (other
ignored traits don't assert, for example).