[webkit-reviews] review requested: [Bug 6484] font-weight does not properly support graded weights : [Attachment 12882] patch v 0.9

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 2 11:12:40 PST 2007

Nicholas Shanks <contact at nickshanks.com> has asked  for review:
Bug 6484: font-weight does not properly support graded weights

Attachment 12882: patch v 0.9

------- Additional Comments from Nicholas Shanks <contact at nickshanks.com>
working patch for feedback. addresses every issue mentioned on either my or
alex's patches.
does not include tests or changelog yet

1) I am not sure if all my "using namespace" and "@namespace" changes are
2) The FontManager <=> CSS weight conversion table needs tweaking (or something
else does) since "normal" gives a Light weight and "bold" gives an Extra Bold
weight. This is not considered significant for the purposes of the review
3) Does not assert on NSBoldFontMask being passed in. Trait is ignored anyway,
and no longer used elsewhere so I don't see it necessary to assert (other
ignored traits don't assert, for example).

More information about the webkit-reviews mailing list