[webkit-reviews] review requested: [Bug 12287] Patch: make most of Frame platform independent : [Attachment 12881] new version

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 2 10:44:28 PST 2007

Lars Knoll <lars at trolltech.com> has asked  for review:
Bug 12287: Patch: make most of Frame platform independent

Attachment 12881: new version

------- Additional Comments from Lars Knoll <lars at trolltech.com>
Sorry about the length of the patch. It's a bit because of timezone issues that
make it hard for me to get an intermediate review of smaller pieces. 

Added the 0 pointer check for page and used d->m_editor throughout Frame.cpp.
Also removed all tabs that sneaked in.

I agree that windowScriptObject should have a different name. I'm not changing
it now, as I currently don't have access to a mac.

And: I would very much vote for having the same coding style in C++ and objc.
anything else is highly confusing.

More information about the webkit-reviews mailing list