[webkit-reviews] review granted: [Bug 16682] array_object.cpp needs
a bath : [Attachment 18201] Remove minInt, maxInt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 30 22:24:24 PST 2007
Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16682: array_object.cpp needs a bath
http://bugs.webkit.org/show_bug.cgi?id=16682
Attachment 18201: Remove minInt, maxInt
http://bugs.webkit.org/attachment.cgi?id=18201&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
This looks good, though I am not used to seeing the std::max/min with a
template parameter. Are you sure that is kosher? Also, I think the change to
do-webcore-rename should go in a separate commit. And you need CHANGELOGS.
More information about the webkit-reviews
mailing list