[webkit-reviews] review granted: [Bug 16672] Number.toString does
not throw exceptions like it should : [Attachment 18180]
Reviewed by Sam.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 30 00:37:46 PST 2007
Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16672: Number.toString does not throw exceptions like it should
http://bugs.webkit.org/show_bug.cgi?id=16672
Attachment 18180: Reviewed by Sam.
http://bugs.webkit.org/attachment.cgi?id=18180&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
This can be move up a little to return a little earlier.
+ double x = v->toNumber(exec);
+ if (isnan(x) || isinf(x))
+ return jsString(UString::from(x));
The change to object.cpp seems unrelated.
We should also test toString() with a fractional argument.
r=me
More information about the webkit-reviews
mailing list