[webkit-reviews] review requested: [Bug 16672] Number.toString does
not throw exceptions like it should : [Attachment 18180]
Reviewed by Sam.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 30 00:17:58 PST 2007
Eric Seidel <eric at webkit.org> has asked for review:
Bug 16672: Number.toString does not throw exceptions like it should
http://bugs.webkit.org/show_bug.cgi?id=16672
Attachment 18180: Reviewed by Sam.
http://bugs.webkit.org/attachment.cgi?id=18180&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.
* kjs/number_object.cpp:
(KJS::numberToString):
* kjs/object.cpp:
(KJS::Error::create): Remove bogus debug lines.
---
JavaScriptCore/ChangeLog | 12 +++
JavaScriptCore/kjs/number_object.cpp | 100 +++++++++++---------
JavaScriptCore/kjs/object.cpp | 12 ---
LayoutTests/ChangeLog | 13 +++
.../fast/js/number-toExponential-expected.txt | 12 ++-
LayoutTests/fast/js/number-toExponential.html | 13 +++
LayoutTests/fast/js/number-toString-expected.txt | 25 +++---
LayoutTests/fast/js/resources/number-toString.js | 1 +
8 files changed, 114 insertions(+), 74 deletions(-)
More information about the webkit-reviews
mailing list