[webkit-reviews] review cancelled: [Bug 15960] View source mode displays the attributes after an attribute with an empty value incorrectly. : [Attachment 18053] Proposed patch v1 (with a new regression test)

[bugzilla-daemon at webkit.org]

Anyang Ren <anyang.ren at gmail.com> has cancelled Anyang Ren
<anyang.ren at gmail.com>'s request for review:
Bug 15960: View source mode displays the attributes after an attribute with an
empty value incorrectly.
http://bugs.webkit.org/show_bug.cgi?id=15960

Attachment 18053: Proposed patch v1 (with a new regression test)
http://bugs.webkit.org/attachment.cgi?id=18053&action=edit

------- Additional Comments from Anyang Ren <anyang.ren at gmail.com>
Mitz, you're right.  Thanks for pointing that out.
I studied the code more and I think I understand the
code now.  The key is to study HTMLTokenizer::parseTag.

This patch should be correct, although it may not be the
best fix.

1. I believe that it is not necessary to test attr->value().isNull()
because in HTMLTokenizer::parseTag an attribute with no value is
added with:

  currToken.addAttribute(m_doc, attrName, emptyAtom, inViewSourceMode());

2. I use 'begin' because it equals 'i + 1', which is what I need.
If you think using 'i + 1' is clearer than 'begin', I can do that.