[webkit-reviews] review denied: [Bug 16573] Remove redundant calls to setPrototype in WebCore : [Attachment 18057] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 16573: Remove redundant calls to setPrototype in WebCore
http://bugs.webkit.org/show_bug.cgi?id=16573

Attachment 18057: patch
http://bugs.webkit.org/attachment.cgi?id=18057&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Maciej r- this.  

"I think this introduces a GC hazard. If getting the prototype during
construction actually allocates it, then this could trigger a garbage
collection while an object is half-constructed, which will crash. The current
code is specifically designed to avoid this. You *could* get around this by
always passing in the prototype as a constructor argument and making the
generated code handle this. As long as it is allocated before you start
constructing the wrapper, there is no GC hazard."