[webkit-reviews] review requested: [Bug 13542] gdklauncher doesnt change URL in adress GTKEntry : [Attachment 17936] new patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 16 10:39:55 PST 2007


Luca Bruno <lethalman88 at gmail.com> has asked  for review:
Bug 13542: gdklauncher doesnt change URL in adress GTKEntry
http://bugs.webkit.org/show_bug.cgi?id=13542

Attachment 17936: new patch
http://bugs.webkit.org/attachment.cgi?id=17936&action=edit

------- Additional Comments from Luca Bruno <lethalman88 at gmail.com>
In the previous patch i duplicated the _frame_get_location (mine was
_frame_get_uri, would be this more gtk-y?).
Also i didn't add any uri-related API to the webview, as you can see in the
GtkLauncher the location is retrieved from the main frame.
Didn't add any property because other variables don't have any property.
Notice how get_location won't return a const string anymore.


More information about the webkit-reviews mailing list