[webkit-reviews] review denied: [Bug 16371] Implement additional mouse cursors for Gtk : [Attachment 17817] Updated, using enums, a struct and correct hotspots now

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 16371: Implement additional mouse cursors for Gtk
http://bugs.webkit.org/show_bug.cgi?id=16371

Attachment 17817: Updated, using enums, a struct and correct hotspots now
http://bugs.webkit.org/attachment.cgi?id=17817&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
>-// FIXME: should find better GDK cursors for those than a generic
GDK_LEFT_PTR
>+static GdkCursor* custom_cursor_new(CustomCursorType cursorType)

That can just be a TODO rather than a FIXME. The function should have a
camelCase name since this is WebCore code. (The names of the moz_ variables
don't matter so much, you can leave them as-is.)

>+
> const Cursor& verticalTextCursor()
> {
>-    return pointerCursor();
>+    static Cursor c = custom_cursor_new(CustomCursorVerticalText);
> }

This function is missing a 'return c;'

Could you write a ChangeLog entry, including a mention of where the code was
borrowed from?

Thanks!