[webkit-reviews] review denied: [Bug 16378] Implement Icon for Gtk : [Attachment 17818] Implement Icon for Gtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 05:37:58 PST 2007

Alp Toker <alp at atoker.com> has denied Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 16378: Implement Icon for Gtk

Attachment 17818: Implement Icon for Gtk

------- Additional Comments from Alp Toker <alp at atoker.com>
I didn't check the icon name code yet, but the drawing should almost certainly
be done with cairo and gdk_cairo_set_source_pixbuf() rather than
gdk_draw_pixbuf() so that the drawing operation will integrate with the rest of
the graphics backend.

A ChangeLog, particularly to explain lookupIconName() (which was non-obvious to
me) would be helpful.


More information about the webkit-reviews mailing list