[webkit-reviews] review granted: [Bug 16222] [GTK] Implement inline search and highlighting of matching strings. : [Attachment 17654] Fixed style issues, renamed string to text

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 16222: [GTK] Implement inline search and highlighting of matching strings.
http://bugs.webkit.org/show_bug.cgi?id=16222

Attachment 17654: Fixed style issues, renamed string to text
http://bugs.webkit.org/attachment.cgi?id=17654&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+/**
+ * webkit_web_view_search_text:
+ * @web_view: a #WebKitWebView
+ * @text: a string to look for
+ * @forward: wether to find forward or not
+ * @case_sensitive: wether to respect the case of text
+ * @wrap: wether to continue looking at the beginning after reaching the end
+ *
+ * Looks for a specified string inside #web_view.
+ *
+ * Return value: %TRUE on success or %FALSE on failure
+ */
+gboolean webkit_web_view_search_text(WebKitWebView* webView, const gchar*
string, gboolean forward, gboolean caseSensitive, gboolean shouldWrap)

Do the names of parameters in the documentation need to match their names in
the function definition?

+uint Page::markAllMatchesForText(const String& target, bool caseSensitive,
bool highlight, unsigned limit)

This needs to return an unsigned as well.

r=me, but whoever lands this needs to fix the return type of
markAllMatchesForText.