[webkit-reviews] review requested: [Bug 16222] [GTK] Implement inline search and highlighting of matching strings. : [Attachment 17654] Fixed style issues, renamed string to text

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 16222: [GTK] Implement inline search and highlighting of matching strings.
http://bugs.webkit.org/show_bug.cgi?id=16222

Attachment 17654: Fixed style issues, renamed string to text
http://bugs.webkit.org/attachment.cgi?id=17654&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
I fixed the style issues Adam pointed out. I left the loops for now.

> 102	      bool findString(const String&, bool, bool, bool);

I think that must not be const because it may modify the selection and the
focus.

> Hi Christian. What do you think of webkit_web_view_search_text?

In fact I looked through a few gtk functions again and 'text' is probably the
appropriate term. So I renamed it.