[webkit-reviews] review denied: [Bug 15057] EditorClientGtk is missing some important keypress handling, patch attached : [Attachment 16083] adds missing keypress cases to EditorClientGtk::handleKeypress

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied 's request for review:
Bug 15057: EditorClientGtk is missing some important keypress handling, patch
attached
http://bugs.webkit.org/show_bug.cgi?id=15057

Attachment 16083: adds missing keypress cases to
EditorClientGtk::handleKeypress
http://bugs.webkit.org/attachment.cgi?id=16083&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
This patch looks fine (except for the lack of a ChangeLog entry (see
<http://webkit.org/coding/contributing.html>)), but I'd much rather see us
reduce code duplication rather than increase it.

(In reply to comment #0)

> The QT code is basically identical (neither the GTK nor QT code is specific
to
> that platform) and a way should be found to share the GTK and QT code for
this,
> but I'm leaving that as a separate issue.

I think Windows currently has the most complete code for this. We should work
on moving WebView::interpretKeyEvent and WebView::handleEditingKeyboardEvent
down into WebCore.